Homec4science

Don't log lost connection retries

Authored by epriestley <git@epriestley.com> on Jun 13 2012, 23:42.

Description

Don't log lost connection retries

Summary:
In D1460, we added initial-connection retries and additional logging in response to network/router instability at Facebook.

One of these logs occurs normally, though, when daemons get disconnected by 'wait_timeout' settings. This is noisy for a lot of installs and a few people have asked me about it.

I assume the situation has cleared up a bit at Facebook, so we can remove the "business as usual" log and keep error logs quieter for general installs?

Test Plan: Weathered the support storm.

Reviewers: nh, vrana

Reviewed By: nh

CC: Makinde, aran

Differential Revision: https://secure.phabricator.com/D2736

Details

Committed
epriestley <git@epriestley.com>Jun 13 2012, 23:42
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc868ec7d1158: Extend ManiphestAction from ManiphestConstants, not PhrictionConstants
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH4ac1fa143281: Don't log lost connection retries (authored by epriestley <git@epriestley.com>).Jun 13 2012, 23:42