Homec4science

Don't store IP addresses in content sources

Authored by epriestley <git@epriestley.com> on Oct 21 2015, 21:37.

Description

Don't store IP addresses in content sources

Summary:
We don't use these for anything, we're inconsistent about recording them, and there's some mild interaction with privacy concerns and data retention. Every other log we store any kind of information in can be given a custom retention policy after recent GC changes.

If we did put this back eventually it would probably be better to store a session identifier anyway, since that's more granular and more detailed.

You can fetch this info out of access logs anyway, too.

Test Plan: Left a couple of comments.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D14315

Details

Committed
epriestley <git@epriestley.com>Oct 21 2015, 21:37
Pushed
aubortJan 31 2017, 17:16
Parents
rPH5b619862cb06: Show a more reasonable status element for pull requests
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH4afeebe83489: Don't store IP addresses in content sources (authored by epriestley <git@epriestley.com>).Oct 21 2015, 21:37