Homec4science

Remove retry/failure mechanisms from MetaMTA

Authored by epriestley <git@epriestley.com> on Feb 1 2014, 23:35.

Description

Remove retry/failure mechanisms from MetaMTA

Summary:
Fixes T4202. We have old code in MetaMTA which implements gradual backoff and maximum retries.

However, we have more general code in the task queue which does this, too. We can just use the more general stuff in the task queue; it obsoletes the specific stuff in MetaMTA, which is more complex and ran into some kind of issue in T4202.

Remove retryCount, nextRetry (obsoleted by task queue retry mechanisms) and "simulated failures" (no longer in use).

Generally, modern infrastructure has replaced these mechanisms with more general ones.

Test Plan:

  • Sent mail.
  • Observed unsendable mail failing in reasonable ways in the queue.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T4202

Differential Revision: https://secure.phabricator.com/D8115

Details

Committed
epriestley <git@epriestley.com>Feb 1 2014, 23:35
Pushed
aubortJan 31 2017, 17:16
Parents
rPHbb633fb42afa: Clean up the Diffusion search UI a little bit
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH4b0ef353e48d: Remove retry/failure mechanisms from MetaMTA (authored by epriestley <git@epriestley.com>).Feb 1 2014, 23:35