Homec4science

Fix application order, curing "Log Out" of wanderlust

Authored by epriestley <git@epriestley.com> on Sep 30 2013, 18:38.

Description

Fix application order, curing "Log Out" of wanderlust

Summary:
Fixes T3894. The "Log Out" icon has moved away from its rightmost position in the menubar.

In rP2e5ac12, I added a "Policy" application. This was the root cause.

The reordering logic (below) is slightly wrong. The array_select_keys() call is actually using the strings (like "Admnistration") to select the groups, not the correct constants (like "admin"). Use the constants instead and get the expected group ordering.

Test Plan: Loaded page, "Log Out" is in the rightmost position.

Reviewers: btrahan, chad

Reviewed By: chad

CC: aran

Maniphest Tasks: T3894

Differential Revision: https://secure.phabricator.com/D7177

Details

Committed
epriestley <git@epriestley.com>Sep 30 2013, 18:38
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb592630d7259: Provide more structure to PHUIObjectBoxView
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH4b39cc321b88: Fix application order, curing "Log Out" of wanderlust (authored by epriestley <git@epriestley.com>).Sep 30 2013, 18:38