Allow modern hunks to be stored deflated
4b39fbe1155e
Actions

Authored by epriestley <git@epriestley.com> on May 25 2014, 20:41.

Description

Allow modern hunks to be stored deflated

Summary: Ref T4045. Ref T5179. When saving a modern hunk, deflate it if we have the function and deflating it will save a nontrivial number of bytes.

Test Plan:

Used bin/hunks migrate to move some hunks over, saw ~70-80% compression on most standard hunks.
Viewed changesets using compressed hunks.
Profiled gzinflate() and verified the cost is trivial (<< 1ms) at least for normal diffs.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T4045, T5179

Committed

epriestley <git@epriestley.com>

Jun 4 2014, 03:01

Pushed

aubort

Jan 31 2017, 17:16

Parents

Branches

Unknown

Tags

Unknown

epriestley <git@epriestley.com> committed rPH4b39fbe1155e: Allow modern hunks to be stored deflated (authored by epriestley <git@epriestley.com>).Jun 4 2014, 03:01

				Path
	M			src/applications/cache/PhabricatorCaches.php
	M			src/applications/cache/PhabricatorKeyValueDatabaseCache.php
	M			src/applications/differential/management/PhabricatorHunksManagementMigrateWorkflow.php
	M			src/applications/differential/storage/DifferentialHunkModern.php