Homec4science

Introduce PHUIRemarkupView, a sane way to work with Remarkup

Authored by epriestley <git@epriestley.com> on Oct 15 2015, 19:20.

Description

Introduce PHUIRemarkupView, a sane way to work with Remarkup

Summary:
Fixes T9273. Remarkup has reasonably good fundamentals but the API is a giant pain to work with.

Provide a PHUIRemarkupView to make it easier. This object is way simpler to use by default.

It's not currently as powerful, but we can expand the power level later by adding more setters.

Eventually I'd expect to replace PhabricatorRemarkupInterface and PhabricatorMarkupOneOff with this, but no rush on those.

I converted a few callsites as a sanity check that it works OK.

Test Plan:

  • Viewed remarkup in Passphrase.
  • Viewed remarkup in Badges.
  • Viewed a Conduit method.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9273

Differential Revision: https://secure.phabricator.com/D14289

Details

Committed
epriestley <git@epriestley.com>Oct 15 2015, 19:20
Pushed
aubortJan 31 2017, 17:16
Parents
rPH034ff3c8708f: Remove "_-_" -> "-" slug behavior
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH4b43667086ae: Introduce PHUIRemarkupView, a sane way to work with Remarkup (authored by epriestley <git@epriestley.com>).Oct 15 2015, 19:20