Homec4science

Throw a richer exception when updating tasks with expired leases

Authored by epriestley <git@epriestley.com> on Dec 17 2012, 01:27.

Description

Throw a richer exception when updating tasks with expired leases

Summary: Include task ID and class when raising this exception. I took a brief stab at doing this generically, but (a) we specifically raise this exception outside of normal try/catch because we can't follow normal recovery rules for it and (b) we don't have a reasonable PhutilProxyException or similar right now which would preserve stack traces, and don't have builtin exception nesting support until PHP 5.3.

Test Plan: Faked this exception, verified we get more information in the logs.

Reviewers: btrahan, vrana

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2193

Differential Revision: https://secure.phabricator.com/D4205

Details

Committed
epriestley <git@epriestley.com>Dec 17 2012, 01:27
Pushed
aubortJan 31 2017, 17:16
Parents
rPH09f543e2e2f1: Align table cell content in Diffusion.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH4c7c518c6370: Throw a richer exception when updating tasks with expired leases (authored by epriestley <git@epriestley.com>).Dec 17 2012, 01:27