Homec4science

Remove all calls to renderSingleView() and deprecate it

Authored by epriestley <git@epriestley.com> on Mar 9 2013, 22:52.

Description

Remove all calls to renderSingleView() and deprecate it

Summary: After D5305, this method does nothing since we automatically figure out what we need to do.

Test Plan:

  • Viewed a page with the main menu on it (MainMenuView).
  • Viewed a revision with transactions on it (TransactionView).
  • Viewed timeline UIExample (TimelineView, TimelineEventView).
  • Viewed a revision (PropertyListView).
  • Viewed a profile (ProfileHeaderView).
  • Viewed Pholio list (PinboardView, PinboardItemView).
  • Viewed Config (ObjectItemView, ObjectItemListView).
  • Viewed Home (MenuView).
  • Viewed a revision (HeaderView, CrumbsView, ActionListView).
  • Viewed a revision with an inline comment (anchorview).
  • Viewed a Phriction diff page (AphrontCrumbsView).
    • Filed T2721 to get rid of this.
  • Looked at Pholio and made inlines and comments (mockimages, pholioinlinecomment/save/edit).
  • Looked at conpherences.
  • Browsed around.

Reviewers: chad, vrana

Reviewed By: chad

CC: edward, aran

Differential Revision: https://secure.phabricator.com/D5307

Details

Committed
epriestley <git@epriestley.com>Mar 9 2013, 22:52
Pushed
aubortJan 31 2017, 17:16
Parents
rPH5e41ead7c797: Have AphrontView implement PhutilSafeHTMLProducerInterface
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH4c914a5c4937: Remove all calls to renderSingleView() and deprecate it (authored by epriestley <git@epriestley.com>).Mar 9 2013, 22:52