Homec4science

Add DoorkeeperExternalObjectQuery, expose more ref/import APIs

Authored by epriestley <git@epriestley.com> on Jun 26 2013, 01:30.

Description

Add DoorkeeperExternalObjectQuery, expose more ref/import APIs

Summary:
Ref T2852.

  • Broadly, we support "I have a Ref, I need a PHID" well but not "I have a PHID, I need a Ref".
  • Add DoorkeeperExternalObjectQuery, and use it to query ExternalObjects.
  • Allow external objects to be imported by their internal PHIDs. Basically, if we have an edge pointing at an ExternalObject, we can say "load all the data about this" from just the PHID and have it hit all the same code.
  • Allow construction of Refs from ExternalObjects. This makes the "I have a PHID, I need a Ref" easier.

Test Plan:

  • Verified Asana links still enrich properly at display time.
  • Used in future revision.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2852

Differential Revision: https://secure.phabricator.com/D6294

Details

Committed
epriestley <git@epriestley.com>Jun 26 2013, 01:30
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc77bfd660374: Make EdgeQuery return `array()` for empty data instead of `null`
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH4ca38612f2b0: Add DoorkeeperExternalObjectQuery, expose more ref/import APIs (authored by epriestley <git@epriestley.com>).Jun 26 2013, 01:30