Homec4science

[releeph] Conduit failure with bad IDs

Authored by Scott MacVicar <scott@macvicar.net> on Oct 15 2013, 01:07.

Description

[releeph] Conduit failure with bad IDs

Summary:
Instead of returning a blank result it throws exceptions. Fix this up a
little so we get some consistency with differential

Test Plan:
Loaded a bad phid for releeph, returns empty list.
Try a good phid and get 2 releeph merges.

Reviewers: epriestley, elenaperezrioja, dschleimer, #blessed_reviewers

Reviewed By: epriestley

CC: Korvin, epriestley, aran

Differential Revision: https://secure.phabricator.com/D7302

Details

Committed
Scott MacVicar <scott@macvicar.net>Oct 15 2013, 01:07
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc4abf160cc51: Fix some file policy issues and add a "Query Workspace"
Branches
Unknown
Tags
Unknown

Event Timeline

Scott MacVicar <scott@macvicar.net> committed rPH4d1709651e4e: [releeph] Conduit failure with bad IDs (authored by Scott MacVicar <scott@macvicar.net>).Oct 15 2013, 01:07