Homec4science

Ignore repository versions on inactive devices in "Repository Servers" panel in…

Authored by epriestley <git@epriestley.com> on Sep 5 2016, 19:34.

Description

Ignore repository versions on inactive devices in "Repository Servers" panel in Config

Summary:
Fixes T11590. Currently, we incorrectly consider cluster repository versions that are (or were) on devices which are no longer part of the active cluster service when building this status screen.

Instead, ignore them. This is just a display bug; the actual ClusterEngine already had similar logic.

Test Plan:

  • Added a bad leader record to repository_workingcopyversion.
  • Before patch, got a bad "Partial (1w)" sync:

{F1802292}

  • After patch, got a good "Sycnchronized":

{F1802293}

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11590

Differential Revision: https://secure.phabricator.com/D16492

Details

Committed
epriestley <git@epriestley.com>Sep 5 2016, 20:10
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc38bc3988d7a: Rebuild CSS packages
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH4dc37bcee080: Ignore repository versions on inactive devices in "Repository Servers" panel in… (authored by epriestley <git@epriestley.com>).Sep 5 2016, 20:10