Homec4science

Don't fail in Diffusion if .gitmodules is missing

Authored by epriestley <git@epriestley.com> on Jul 5 2012, 15:12.

Description

Don't fail in Diffusion if .gitmodules is missing

Summary:
See T1448. If this file isn't present, just move on instead of failing, since it's a (sort of) legitimate repository state.

Also fix some silliness a little later that got introduced in refactoring, I think.

Test Plan: Added an external to my test repo and removed ".gitmodules". Verified that the directory is now viewable after this patch.

Reviewers: btrahan, davidreuss, jungejason

Reviewed By: davidreuss

CC: aran

Maniphest Tasks: T1448

Differential Revision: https://secure.phabricator.com/D2922

Details

Committed
epriestley <git@epriestley.com>Jul 5 2012, 15:12
Pushed
aubortJan 31 2017, 17:16
Parents
rPHbf9cd5557758: Minor, fix an issue where fail to extract the author PHID from an edge…
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH4dd5bcf1cdc3: Don't fail in Diffusion if .gitmodules is missing (authored by epriestley <git@epriestley.com>).Jul 5 2012, 15:12