Merge redundant Herald effect code
4e47e3a11670
Actions

Authored by epriestley <git@epriestley.com> on Apr 22 2015, 23:00.

Description

Merge redundant Herald effect code

Summary: Ref T7849. Lift more action handling out of adapters. In theory, adapters will some day do no action handling. That day is not today, but it is now a step closer.

Test Plan:

Wrote a rule using the email and flag actions.
Ran that rule.
Got an email and flag.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T7849

Differential Revision: https://secure.phabricator.com/D12502

Details

Committed

epriestley <git@epriestley.com>

Apr 22 2015, 23:00

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPH2e8649c29231: Conpherence - sort participant list in a case insensitive way

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH4e47e3a11670: Merge redundant Herald effect code (authored by epriestley <git@epriestley.com>).Apr 22 2015, 23:00

Changes (7)

				Path
	M			src/applications/diffusion/herald/HeraldPreCommitAdapter.php
	M			src/applications/herald/adapter/HeraldAdapter.php
	M			src/applications/herald/adapter/HeraldCommitAdapter.php
	M			src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php
	M			src/applications/herald/adapter/HeraldManiphestTaskAdapter.php
	M			src/applications/herald/adapter/HeraldPholioMockAdapter.php
	M			src/applications/phriction/herald/PhrictionDocumentHeraldAdapter.php