Homec4science

Fix qsprintf() '%nd' conversion

Authored by epriestley <git@epriestley.com> on Dec 14 2011, 02:34.

Description

Fix qsprintf() '%nd' conversion

Summary:
I broke this a little bit in my overzealous D1174, since this block validates
both '%nd' (nullable integer) and '%d' (non-nullable integer).

Clean up the conditional checks so we catch the bad case ('%d' on a PHID
converting to 0) but let the good case ('%nd' with null) through.

Test Plan: Unit tests failed; applied patch; unit tests pass.

Reviewers: btrahan, jungejason

Reviewed By: btrahan

CC: aran, btrahan

Maniphest Tasks: T670

Differential Revision: 1201

Details

Committed
epriestley <git@epriestley.com>Dec 14 2011, 02:40
Pushed
aubortJan 31 2017, 17:16
Parents
rPH2d232674df71: Allow customized patterns for marking generated files.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH4edfd35503c3: Fix qsprintf() '%nd' conversion (authored by epriestley <git@epriestley.com>).Dec 14 2011, 02:40