Homec4science

Remove HeraldDryRunAdapter

Authored by epriestley <git@epriestley.com> on Aug 7 2013, 15:47.

Description

Remove HeraldDryRunAdapter

Summary: Ref T2769. This isn't a real adapter and its methods are increasingly hacky messes. Make "dry run" a first-class concept on the HeraldEngine instead and remove the adapter.

Test Plan: Ran Herald via test console and via CLI.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2769

Differential Revision: https://secure.phabricator.com/D6693

Details

Committed
epriestley <git@epriestley.com>Aug 8 2013, 03:04
Pushed
aubortJan 31 2017, 17:16
Parents
rPHce163536ca93: Add a normal "view" page for Herald rules
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH4f49ec1cff1c: Remove HeraldDryRunAdapter (authored by epriestley <git@epriestley.com>).Aug 8 2013, 03:04