Homec4science

Ignore keys with trailing index on table primary key for now

Authored by epriestley <git@epriestley.com> on Oct 1 2014, 16:55.

Description

Ignore keys with trailing index on table primary key for now

Summary:
Ref T1191. We have several keys on <x, y, id>. When id is an auto-increment primary key, I believe this is exactly equivalent to a key on <x, y>, because the leaf nodes are implicitly sorted by id. We omit the implicit id elsewhere.

It would be nice to drop the id bit for consistency, but it's not doing any harm and this doesn't need to block the primary work of T1191.

Test Plan: Saw slightly fewer warnings.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T1191

Differential Revision: https://secure.phabricator.com/D10592

Details

Committed
epriestley <git@epriestley.com>Oct 1 2014, 16:55
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8bf24f53b334: Destroy surplus columns
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH4f87adc43846: Ignore keys with trailing index on table primary key for now (authored by epriestley <git@epriestley.com>).Oct 1 2014, 16:55