Homec4science

Enable herald rule for commits that need auditing

Authored by jungejason <jun.ge.jason@fb.com> on Jan 14 2012, 08:08.

Description

Enable herald rule for commits that need auditing

Summary:
enable herald commit rules to have access to auditing info.

Note that the new herald condition I added contains info for the
packages. I thought about using a simpler herald condition like
"Requires audit is true or false" and let it work together with the
existing "Affected package contains any of the package". It doesn't work
because we need the info about the package to decide if the commit
requires audit, but the herald conditions work separately.

Test Plan:

  • A commit requiring auditing was detected by a herald rule that checks the auditing status
  • A commit not requiring auditing was not detected by a herald rule which checks auditing status, but was detected by a rule which doesn't check the auditing status

Reviewers: epriestley, nh

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1399

Details

Committed
jungejason <jun.ge.jason@fb.com>Jan 17 2012, 18:13
Pushed
aubortJan 31 2017, 17:16
Parents
rPH05ee317555a0: Remove "parsedHunk" property
Branches
Unknown
Tags
Unknown

Event Timeline

jungejason <jun.ge.jason@fb.com> committed rPH4faab06c3c76: Enable herald rule for commits that need auditing (authored by jungejason <jun.ge.jason@fb.com>).Jan 17 2012, 18:13