Homec4science

Added a big warning if reviewer is about to accept a diff with lint or unit…

Authored by tuomaspelkonen <tuomaspelkonen@fb.com> on Jun 10 2011, 03:56.

Description

Added a big warning if reviewer is about to accept a diff with lint or unit errors.

Summary:
Make sure reviewers know what they are doing.

Test Plan:
Tested with different diffs that had lint and unit problems.

Reviewed By: epriestley
Reviewers: epriestley, jungejason
CC: grglr, aran, epriestley, tuomaspelkonen
Differential Revision: 432

Details

Committed
tuomaspelkonen <tuomaspelkonen@fb.com>Jun 13 2011, 20:49
Pushed
aubortJan 31 2017, 17:16
Parents
rPHeab768f70552: Allow projects to be quickly added from the Maniphest task creation interface
Branches
Unknown
Tags
Unknown

Event Timeline

tuomaspelkonen <tuomaspelkonen@fb.com> committed rPH501c001520ea: Added a big warning if reviewer is about to accept a diff with lint or unit… (authored by tuomaspelkonen <tuomaspelkonen@fb.com>).Jun 13 2011, 20:49