Added a big warning if reviewer is about to accept a diff with lint or unit…
501c001520ea
Actions

Authored by tuomaspelkonen <tuomaspelkonen@fb.com> on Jun 10 2011, 03:56.

Description

Added a big warning if reviewer is about to accept a diff with lint or unit errors.

Summary:
Make sure reviewers know what they are doing.

Test Plan:
Tested with different diffs that had lint and unit problems.

Reviewed By: epriestley
Reviewers: epriestley, jungejason
CC: grglr, aran, epriestley, tuomaspelkonen
Differential Revision: 432

Committed

tuomaspelkonen <tuomaspelkonen@fb.com>

Jun 13 2011, 20:49

Pushed

aubort

Jan 31 2017, 17:16

Parents

Branches

Unknown

Tags

Unknown

				Path
	M			src/__celerity_resource_map__.php
	M			src/applications/differential/view/addcomment/DifferentialAddCommentView.php
	M			src/applications/differential/view/addcomment/__init__.php
	M			src/view/form/error/AphrontErrorView.php
	A			webroot/rsrc/js/application/differential/behavior-accept-with-errors.js