Homec4science

Improved warning message when accepting diff with skipped lint or unit

Authored by Nick Harper <nharper@fb.com> on Feb 28 2012, 01:09.

Description

Improved warning message when accepting diff with skipped lint or unit

Summary:
Some people find the current message stating "This diff has Lint/Unit Test
Problems" confusing if the unit tests or lint was skipped. This revision
clarifies those messages.

Test Plan:
Started to accept a revision with skipped lint and unit tests, and saw the new
message.

Reviewers: epriestley, btrahan, jungejason

Reviewed By: epriestley

CC: aran, epriestley

Differential Revision: https://secure.phabricator.com/D1738

Details

Committed
Nick Harper <nharper@fb.com>Mar 1 2012, 07:39
Pushed
aubortJan 31 2017, 17:16
Parents
rPH4c8f405fccc2: Use wide links only for line and blame-prev in Diffusion
Branches
Unknown
Tags
Unknown

Event Timeline

Nick Harper <nharper@fb.com> committed rPH5042667b96fc: Improved warning message when accepting diff with skipped lint or unit (authored by Nick Harper <nharper@fb.com>).Mar 1 2012, 07:39