Homec4science

Don't run Herald when applying inverse edge transactions

Authored by epriestley <git@epriestley.com> on Dec 11 2014, 01:51.

Description

Don't run Herald when applying inverse edge transactions

Summary: Fixes T6727. Repro is: mention a task on another task, in a comment.

The inverse edge editor applying the "alincoln mentioned this in <other task>" transaction doesn't have enough data to execute Herald rules.

Just don't try to execute the rules, since they don't make much sesne from a product perspective and are tricky from a technical perspective.

Test Plan: Commented on T1 with T2 in comment body and a Herald rule that examines subscribers.

Reviewers: btrahan

NOTE: Cowboy committing this since any task mention fatals.

Details

Committed
epriestley <git@epriestley.com>Dec 11 2014, 01:53
Pushed
aubortJan 31 2017, 17:16
Parents
rPH7d9687057056: Maniphest - use subscribers framework properly
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH5050389fcefc: Don't run Herald when applying inverse edge transactions (authored by epriestley <git@epriestley.com>).Dec 11 2014, 01:53