Homec4science

Don't issue a bazillion queries to load Differential object lists

Authored by epriestley <git@epriestley.com> on Feb 19 2014, 02:57.

Description

Don't issue a bazillion queries to load Differential object lists

Summary:
Ref T3496. Currently, we call loadAssets() on each revision table, which invokes a new revision query and a pile of subqueries.

Instead, add needFlags() and needDrafts() to RevisionQuery. Some day these could perhaps be more generic.

Test Plan:

  • Viewed home, differential, etc., no longer saw 9203809238 queries being run for no reason.
  • Drafts and flags still appear properly.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T3496

Differential Revision: https://secure.phabricator.com/D8277

Details

Committed
epriestley <git@epriestley.com>Feb 19 2014, 02:57
Pushed
aubortJan 31 2017, 17:16
Parents
rPH65bc2b1ac53d: Implement "Pro" version of revision editor, with one field
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH50ed42761ce9: Don't issue a bazillion queries to load Differential object lists (authored by epriestley <git@epriestley.com>).Feb 19 2014, 02:57