Homec4science

Don't activate JX.Scrollbar if we don't need to

Authored by epriestley <git@epriestley.com> on Jan 24 2015, 03:22.

Description

Don't activate JX.Scrollbar if we don't need to

Summary:
See discussion on rPc40bc0c8bf75. Fixes a couple of glitchy things:

  • Things were generally not nice on iOS.
  • On OSX, with no mouse, the OS scrollbar and our fake scrollbar would both draw.
  • Bar z-index was not set quite correctly.

Specifically, check if we need these bars. If we don't, just exit immediately and use the OS bars.

Test Plan:

  • Tested Safari, Firefox, Chrome with and without a mouse.
  • Tested iOS Simualtor.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D11480

Details

Committed
epriestley <git@epriestley.com>Jan 24 2015, 03:22
Pushed
aubortJan 31 2017, 17:16
Parents
rPH8d087ae738d8: Remove 'initFromConduit' option from Diffusion
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH512b17361845: Don't activate JX.Scrollbar if we don't need to (authored by epriestley <git@epriestley.com>).Jan 24 2015, 03:22