Homec4science

Use `window.confirm` instead of `confirm`

Authored by Joshua Spence <josh@joshuaspence.com> on Dec 30 2014, 11:54.

Description

Use window.confirm instead of confirm

Summary:
This silences the following JSHint warning:

>>> Lint for webroot/rsrc/js/application/uiexample/notification-example.js:

   Warning  (W117) JSHintW117
    'confirm' is not defined.

              39           notification.listen(
              40             'activate',
              41             function() {
    >>>       42               if (!confirm('Close notification?')) {
              43                 JX.Stratcom.context().kill();
              44               }
              45             });

Test Plan: arc lint

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: Korvin, epriestley

Differential Revision: https://secure.phabricator.com/D11065

Details

Committed
epriestley <git@epriestley.com>Dec 30 2014, 11:55
Pushed
aubortJan 31 2017, 17:16
Parents
rPH558e1ee3b8d2: Define JavaScript functions before they are used
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH5251f08fb432: Use `window.confirm` instead of `confirm` (authored by Joshua Spence <josh@joshuaspence.com>).Dec 30 2014, 11:55