Homec4science

Scope "in-flight" PHIDs more carefully

Authored by epriestley <git@epriestley.com> on May 8 2015, 06:10.

Description

Scope "in-flight" PHIDs more carefully

Fixes T8125. In Feed, we query for a bunch of objects and also a bunch of transactions.

The transactions require the objects. Normally, whichever executes last will fill out of the Workspace cheaply, so this query strategy is fine overall.

The new "in-flight" code would mark everything in flight before the transactions loaded, though, so they'd fail to load even though the query plan is not cyclic.

Instead, be more surgical and mark things in flight only immediately before we put them in flight.

Test Plan: Feed now shows more stories again; files with cycles still load in finite time.

Auditors: btrahan

Details

Committed
epriestley <git@epriestley.com>May 8 2015, 06:10
Pushed
aubortJan 31 2017, 17:16
Parents
rPHf3d76a90f0e3: Translate "All Day" events into the viewer's time
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH528f1a97449e: Scope "in-flight" PHIDs more carefully (authored by epriestley <git@epriestley.com>).May 8 2015, 06:10