Homec4science

Move "Rendering References" to the DifferentialChangesetParser level

Authored by epriestley <git@epriestley.com> on May 12 2011, 06:46.

Description

Move "Rendering References" to the DifferentialChangesetParser level

Summary:
Separates changeset IDs from rendering. Now each changeset has a "rendering
reference" which is basically a description of what the ajax endpoint should
render. For Differential, it's in the form "id/vs". For Diffusion,
"branch/path;commit".

I believe this fixes pretty much all of the bugs related to "show more" breaking
in various obscure ways, although I never got a great repro for T153.

Test Plan:
Clicked "show more" in diffusion change and commit views and differential diff,
diff-of-diff, standalone-diff, standalone-diff-of-diff views. Verified refs and
'whitespace' were always sent correctly.

Made inline comments on diffs and diffs-of-diffs. Used "Reply".

Reviewed By: tuomaspelkonen
Reviewers: tuomaspelkonen, jungejason, aran
CC: aran, tuomaspelkonen, epriestley
Differential Revision: 274

Details

Committed
epriestley <git@epriestley.com>May 13 2011, 15:10
Pushed
aubortJan 31 2017, 17:16
Parents
rPH63f6d807c5ea: Update Celerity map.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH54154e4f48d0: Move "Rendering References" to the DifferentialChangesetParser level (authored by epriestley <git@epriestley.com>).May 13 2011, 15:10