Homec4science

IRC Macro Handler - check result from conduit call before operating on it

Authored by Bob Trahan <bob.trahan@gmail.com> on May 17 2012, 23:55.

Description

IRC Macro Handler - check result from conduit call before operating on it

Summary: 'cuz github issue 114 came into existence. instead, just return false early here. note i am not sure if I should phlog that this is happening or not but its not exception worthy IMO.

Test Plan: lint-only 'cuz i don't want to setup an IRC server locally / somehow get my local phabricator instance accessible out there. happy to test end to end if there's an easier way...!

Reviewers: vrana, epriestley

Reviewed By: vrana

CC: aran, Koolvin

Differential Revision: https://secure.phabricator.com/D2490

Details

Committed
Bob Trahan <bob.trahan@gmail.com>May 17 2012, 23:55
Pushed
aubortJan 31 2017, 17:16
Parents
rPH60696de09511: Fix default limit in elasticsearch
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPH5475a1bec707: IRC Macro Handler - check result from conduit call before operating on it (authored by Bob Trahan <bob.trahan@gmail.com>).May 17 2012, 23:55