Homec4science

Separate commit message parsing and validation from Conduit

Authored by epriestley <git@epriestley.com> on Dec 14 2016, 16:59.

Description

Separate commit message parsing and validation from Conduit

Summary:
Ref T11114. I want to move this step away from custom fields. To start with, isolate all the parsing in one class with a clearer API boundary.

Next, I'll make this class use new field objects to perform parsing, without CustomField interactions.

Test Plan: Created and edited revisions from the CLI, using valid and invalid commit messages.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114

Differential Revision: https://secure.phabricator.com/D17055

Details

Committed
epriestley <git@epriestley.com>Dec 14 2016, 23:14
Pushed
aubortJan 31 2017, 17:16
Parents
rPH3d8d98bd8deb: Probably (?) fix two very old project slug migrations
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH552c54668988: Separate commit message parsing and validation from Conduit (authored by epriestley <git@epriestley.com>).Dec 14 2016, 23:14