Homec4science

Raise PhabricatorShapedRequest request timeout

Authored by epriestley <git@epriestley.com> on May 22 2011, 18:27.

Description

Raise PhabricatorShapedRequest request timeout

Summary:
We hit this very short (1s) timeout when the browser chooses to resolve all the
diff requests before the preview request. In the long term we could start the
preview request only after all the diff requests resolve, but this solves the
issue for now and there's no reason for such a short timeout.

The historical reason to have this timeout at all is that intern was megaflaky
and that's no longer a problem.

Test Plan:
Faked it so it would use a 1ms timeout the first time and then a 20s timeout;
got reasonable behavior.

Reviewed By: aran
Reviewers: jungejason, tuomaspelkonen, aran
CC: aran
Differential Revision: 329

Details

Committed
epriestley <git@epriestley.com>May 22 2011, 23:48
Pushed
aubortJan 31 2017, 17:16
Parents
rPH9f65a5efb8b9: Drag-and-drop upload for Maniphest
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH553c6c78fe8a: Raise PhabricatorShapedRequest request timeout (authored by epriestley <git@epriestley.com>).May 22 2011, 23:48