Homec4science

Tune cookie behaviors for 'phcid', 'phreg', etc

Authored by epriestley <git@epriestley.com> on Mar 14 2014, 22:33.

Description

Tune cookie behaviors for 'phcid', 'phreg', etc

Summary:
Fixes T3471. Specific issues:

  • Add the ability to set a temporary cookie (expires when the browser closes).
  • We overwrote 'phcid' on every page load. This creates some issues with browser extensions. Instead, only write it if isn't set. To counterbalance this, make it temporary.
  • Make the 'next_uri' cookie temporary.
  • Make the 'phreg' cookie temporary.
  • Fix an issue where deleted cookies would persist after 302 (?) in some cases (this is/was 100% for me locally).

Test Plan:

  • Closed my browser, reopned it, verified temporary cookies were gone.
  • Logged in, authed, linked, logged out.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Maniphest Tasks: T3471

Differential Revision: https://secure.phabricator.com/D8537

Details

Committed
epriestley <git@epriestley.com>Mar 14 2014, 22:33
Pushed
aubortJan 31 2017, 17:16
Parents
rPH3ff9f5f48a45: Transactions - add "and X others" dialog support to application transactions
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH559c0fe88663: Tune cookie behaviors for 'phcid', 'phreg', etc (authored by epriestley <git@epriestley.com>).Mar 14 2014, 22:33