Homec4science

Use HTTPEngineExtension proxy for `git` HTTP operations

Authored by epriestley <git@epriestley.com> on Jun 9 2016, 20:19.

Description

Use HTTPEngineExtension proxy for git HTTP operations

Summary: Ref T10227. When we perform git http operations (fetch, mirror) check if we should use a proxy; if we should, set http_proxy or https_proxy in the environment to make git have curl use it.

Test Plan:

  • Configured a proxy extension to run stuff through a local instance of Charles.
  • Ran repository pull and repository mirror.
  • Saw git HTTP requests route through the proxy.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10227

Differential Revision: https://secure.phabricator.com/D16092

Details

Committed
epriestley <git@epriestley.com>Jun 9 2016, 21:17
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa88329fc38c2: Implement basic differential.revision.search
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH55a698a28a75: Use HTTPEngineExtension proxy for `git` HTTP operations (authored by epriestley <git@epriestley.com>).Jun 9 2016, 21:17