Homec4science

Don't prompt to upgrade unset passwords

Authored by epriestley <git@epriestley.com> on Feb 20 2014, 17:12.

Description

Don't prompt to upgrade unset passwords

Summary:
Fixes T4463. When your VCS or account password is not set, we test it for upgrade anyway. This doesn't make sense and throws shortly into the process because the empty hash isn't parseable.

Instead, only show upgrade prompts when the password exists.

Test Plan:

  • Added a password to an existing account with no password via password reset.
  • Added a VCS password to an existing account with no VCS password.
  • Observed no fatals / nonsense behaviors.

Reviewers: btrahan, chad

Reviewed By: chad

CC: aran

Maniphest Tasks: T4463

Differential Revision: https://secure.phabricator.com/D8282

Details

Committed
epriestley <git@epriestley.com>Feb 20 2014, 17:12
Pushed
aubortJan 31 2017, 17:16
Parents
rPH65a3aa0cc758: Remove phui-box-inner
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH55a94d8aba2a: Don't prompt to upgrade unset passwords (authored by epriestley <git@epriestley.com>).Feb 20 2014, 17:12