Homec4science

Fix possible recursive embeds in Dashboard text panels

Authored by epriestley <git@epriestley.com> on Aug 27 2015, 02:59.

Description

Fix possible recursive embeds in Dashboard text panels

Summary:
We currently detect tab panels embedding themselves, but do not detect text panels embedding themselves with {Wxx}.

Detect these self-embedding panels.

I had to add a bit of a hack to pass the parent panel PHIDs to the rule. Generally, I got the Markup API kind of wrong and want to update it, I'll file a followup with details about how I'd like to move forward.

Test Plan:
Created a text panel embedding itself, a tab panel embedding a text panel embedding itself, a tab panel embedding a text panel embedding the tab panel, etc.

Rendered all panels standalone and as {Wxx} from a different context.

{F761158}

{F761159}

{F761160}

{F761161}

{F761162}

Reviewers: chad, jbeta

Reviewed By: chad, jbeta

Differential Revision: https://secure.phabricator.com/D13999

Details

Committed
epriestley <git@epriestley.com>Aug 27 2015, 02:59
Pushed
aubortJan 31 2017, 17:16
Parents
rPH10966519e2eb: Prevent "commit message magic words" parser from exploding on "reverts aaaa.....
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH55b44f53f87f: Fix possible recursive embeds in Dashboard text panels (authored by epriestley <git@epriestley.com>).Aug 27 2015, 02:59