Homec4science

Stop using loadRelationships in differential related herald adapters

Authored by Juan Pablo Civile <elementohb@gmail.com> on Oct 5 2013, 01:30.

Description

Stop using loadRelationships in differential related herald adapters

Summary:
Used DifferentialRevisionQuery with the relevant need*() calls in the test controller.
And started assuming the revision has reviewers and CC phids in HeraldDifferentialRevisionAdapter.

Test Plan:
Added herald rules that use revisions (one for revisions another for commit) and reviewers.
Created, accepted and landed a revision that matched the rules and checked all rules were applied.

Reviewers: epriestley

Reviewed By: epriestley

CC: aran, Korvin

Maniphest Tasks: T1279

Differential Revision: https://secure.phabricator.com/D6468

Conflicts:
src/applications/herald/adapter/HeraldCommitAdapter.php
src/applications/herald/adapter/HeraldDifferentialRevisionAdapter.php
src/applications/herald/controller/HeraldTestConsoleController.php

Details

Committed
epriestley <git@epriestley.com>Oct 5 2013, 01:40
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc35b93d9b63d: lipsum - tighten up some test data generation
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH562da7e98bf0: Stop using loadRelationships in differential related herald adapters (authored by Juan Pablo Civile <elementohb@gmail.com>).Oct 5 2013, 01:40