Homec4science

Modernize DifferentialInlineCommentQuery

Authored by epriestley <git@epriestley.com> on Apr 20 2015, 23:33.

Description

Modernize DifferentialInlineCommentQuery

Summary:
Ref T7447. This class is currently a big mess with a lot of withWeirdSpecialThingUsedInOnePlace() type qualifiers.

Try to generalize/normalize it a bit.

Test Plan:

  • Viewed inline comments.
  • Created a new inline comment.
  • Edited an inline comment.
  • Marked an inline comment complete.
  • Deleted, then undeleted an inline comment.
  • Previewed inline comments.
  • Viewed drafts as another user, verified they don't show up.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: yelirekim, epriestley

Maniphest Tasks: T7447

Differential Revision: https://secure.phabricator.com/D12483

Details

Committed
epriestley <git@epriestley.com>Apr 21 2015, 20:06
Pushed
aubortJan 31 2017, 17:16
Parents
rPH2fab72d43bf6: Quicksand - update title while navigating about
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH5645a07d9984: Modernize DifferentialInlineCommentQuery (authored by epriestley <git@epriestley.com>).Apr 21 2015, 20:06