Homec4science

Reduce code duplication for inline "Undo"

Authored by epriestley <git@epriestley.com> on Mar 8 2015, 23:27.

Description

Reduce code duplication for inline "Undo"

Summary:
Ref T2009. This is another almost-identical copy of the row scaffolding, which has the same 1up/2up bugs as the 8 other copies of this code.

Turn the "undo" element into an InlineCommentView so we can scaffold it.

Then, scaffold it with the same code as everything else.

Test Plan: Hit "Undo", swapped from 1up to 2up, hit "undo" again, swapped back, tried left/right, everything rendered with proper scaffolding.

Reviewers: btrahan, chad

Reviewed By: chad

Subscribers: epriestley

Maniphest Tasks: T2009

Differential Revision: https://secure.phabricator.com/D12019

Details

Committed
epriestley <git@epriestley.com>Mar 9 2015, 18:26
Pushed
aubortJan 31 2017, 17:16
Parents
rPH355142fcbf23: Reduce code duplication on comment editing UI
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH56a970900856: Reduce code duplication for inline "Undo" (authored by epriestley <git@epriestley.com>).Mar 9 2015, 18:26