Homec4science

Improve exception reporting behavior for core exceptions

Authored by epriestley <git@epriestley.com> on Jan 21 2014, 23:03.

Description

Improve exception reporting behavior for core exceptions

Summary:
See https://github.com/facebook/phabricator/issues/487. If an exception is thrown too high in the stack for the main exception handling to deal with it, we currently never report a stack trace. Instead:

  • Always report a stack trace to the error log.
  • With developer mode, also report a stack trace to the screen.

Test Plan: Added a high-level throw and hit both cases. Got traces in the log and traces-under-developer-mode on screen.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Differential Revision: https://secure.phabricator.com/D8022

Details

Committed
epriestley <git@epriestley.com>Jan 21 2014, 23:03
Pushed
aubortJan 31 2017, 17:16
Parents
rPHc9a0ffa1cfaf: Verify that SVN repository roots really are repository roots
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH56bcb33a1891: Improve exception reporting behavior for core exceptions (authored by epriestley <git@epriestley.com>).Jan 21 2014, 23:03