Improve code structure of PHID fields in EditEngine
56be70056111
Actions

Authored by epriestley <git@epriestley.com> on Nov 29 2015, 22:24.

Description

Improve code structure of PHID fields in EditEngine

Summary: Ref T9132. I had some hacks in place for dealing with Edge/Subscribers stuff. Clean that up so it's structured a little better.

Test Plan:

Edited subscribers and projects.
Verified things still show up in Conduit.
Made concurrent edits (added a project in one window, removed it in another window, got a clean result with a correct merge of the two edits).

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T9132

Committed

epriestley <git@epriestley.com>

Nov 30 2015, 18:00

Pushed

aubort

Jan 31 2017, 17:16

Parents

Branches

Unknown

Tags

Unknown

epriestley <git@epriestley.com> committed rPH56be70056111: Improve code structure of PHID fields in EditEngine (authored by epriestley <git@epriestley.com>).Nov 30 2015, 18:00

				Path
	M			src/__phutil_library_map__.php
	A			src/aphront/httpparametertype/AphrontListHTTPParameterType.php
	M			src/aphront/httpparametertype/AphrontPHIDListHTTPParameterType.php
	M			src/aphront/httpparametertype/AphrontProjectListHTTPParameterType.php
	M			src/aphront/httpparametertype/AphrontStringListHTTPParameterType.php
	M			src/aphront/httpparametertype/AphrontUserListHTTPParameterType.php
	M			src/applications/project/editor/PhabricatorProjectsEditEngineExtension.php
	M			src/applications/subscriptions/editor/PhabricatorSubscriptionsEditEngineExtension.php
	M			src/applications/transactions/editengine/PhabricatorEditEngine.php
	M			src/applications/transactions/editfield/PhabricatorEditField.php
	A			src/applications/transactions/editfield/PhabricatorPHIDListEditField.php
	M			src/applications/transactions/editfield/PhabricatorTokenizerEditField.php