Homec4science

don't add email addresses to CC if they are already in TO

Authored by Tal Shiri <eiopaa@gmail.com> on Jul 18 2014, 03:32.

Description

don't add email addresses to CC if they are already in TO

Summary:
Some mailers remove the duplicate entries themselves, but some (Mailgun) don't.
This affects installations with metamta.one-mail-per-recipient set to false, and will cause

  • ugly looking "to" entries. Gmail, for example, collapses to+cc entries to one list, so you get something that looks like "to: me me john"
  • It sometimes causes duplicate delivery of the same message when used in conjuction with Google Groups. I suspect that their message de-dup mechanism is confused by it (I fuzzed it directly with Mailgun, and saw the same message delivered twice - once directly through mailgun, and bounced again through Google Groups). This doesn't happen when the entries are not duplicated.

Test Plan: Created some tasks. Added subscribers. Things seem to work reasonably well.

Reviewers: epriestley, #blessed_reviewers

Reviewed By: epriestley, #blessed_reviewers

Subscribers: epriestley, Korvin

Differential Revision: https://secure.phabricator.com/D9978

Details

Committed
epriestley <git@epriestley.com>Jul 18 2014, 03:32
Pushed
aubortJan 31 2017, 17:16
Parents
rPHbd3c239d5aad: Remove a stray `setActor()` on EdgeEditor
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH570a78d42af7: don't add email addresses to CC if they are already in TO (authored by Tal Shiri <eiopaa@gmail.com>).Jul 18 2014, 03:32