Homec4science

Differential - re-jigger mail such that inline comments show up right after the…

Authored by Bob Trahan <btrahan@phacility.com> on Jan 15 2015, 02:23.

Description

Differential - re-jigger mail such that inline comments show up right after the main comments.

Summary: Ref T6962. Mainly accomplished by re-factoring the base editor buildMailBody function and then using it differently in the DifferentialTransactionEditor.

Test Plan: commented on a revision leaving inline feedback. inspected via bin/mail and it looked good! also made a maniphest comment and checked that email, which still looked good.

Reviewers: chad, epriestley

Reviewed By: epriestley

Subscribers: Korvin, epriestley

Maniphest Tasks: T6962

Differential Revision: https://secure.phabricator.com/D11402

Details

Committed
Bob Trahan <btrahan@phacility.com>Jan 15 2015, 02:23
Pushed
aubortJan 31 2017, 17:16
Parents
rPH923096efc80f: Config - add phd.variant-config to suppress "Daemon & Web config" error message…
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <btrahan@phacility.com> committed rPH57761ce2202a: Differential - re-jigger mail such that inline comments show up right after the… (authored by Bob Trahan <btrahan@phacility.com>).Jan 15 2015, 02:23