Homec4science

Probably improve behavior around duplicate notifications

Authored by epriestley <git@epriestley.com> on Apr 27 2016, 01:27.

Description

Probably improve behavior around duplicate notifications

Summary:
We're sometimes getting duplicate notifications right now. I think this is because multiple windows are racing and becoming leaders.

Clean this up a little:

  • Fix the timeoout typo.
  • Only try to usurp once.
  • Use different usurp and expire delays, so we don't fire them at the exact same time.

Not sure if this'll work or not but it should theoretically be a little cleaner.

Test Plan:

  • Quit Safari, reopened Safari, still saw a fast reconnect to the notification server (this is the goal of usurping).
  • Did normal notification stuff like opening a chat in two windows, got notifications.
  • Hard to reproduce the race for sure, but this at least fixes the outright timeoout bug.

Reviewers: chad

Reviewed By: chad

Differential Revision: https://secure.phabricator.com/D15806

Details

Committed
epriestley <git@epriestley.com>Apr 27 2016, 12:56
Pushed
aubortJan 31 2017, 17:16
Parents
rPH467c4e84e5ac: Add an edge table to the `search` database
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH58b55c2fa6d4: Probably improve behavior around duplicate notifications (authored by epriestley <git@epriestley.com>).Apr 27 2016, 12:56