Homec4science

Use correct viewer for debug.stop-on-redirect

Authored by epriestley <git@epriestley.com> on Apr 8 2014, 19:27.

Description

Use correct viewer for debug.stop-on-redirect

Summary:
See https://github.com/facebook/phabricator/pull/563.

I think this secondary construction of a $user is very old, and predates subsequent changes which cause a proper user to construct earlier, so using the user on the $request should (I think) always work. I couldn't immediately find any cases where it does not.

Test Plan: With debug.stop-on-redirect set, hit various redirects, like jump-naving to T1. Got a proper stop dialog.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D8718

Details

Committed
epriestley <git@epriestley.com>Apr 8 2014, 19:27
Pushed
aubortJan 31 2017, 17:16
Parents
rPHb937bf5946f8: Spell "eventually" correctly, eventually.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH58ba8e7d6359: Use correct viewer for debug.stop-on-redirect (authored by epriestley <git@epriestley.com>).Apr 8 2014, 19:27