Homec4science

Hovercards - make 'em work a bit better

Authored by Bob Trahan <bob.trahan@gmail.com> on Apr 17 2013, 03:25.

Description

Hovercards - make 'em work a bit better

Summary:
this diff makes hovercards load and draw but a single time as appropos; pre-diff we could hammer the server by moving the mouse a bunch before the initial load and the re-draw event was continuously firing.

also makes hovercards work inside whacked out divs like the Conpherence message panel. Fixes T2949.

Test Plan: played with conpherence and phriction, observing hovercards showing up like they should

Reviewers: epriestley, chad

Reviewed By: epriestley

CC: AnhNhan, aran, Korvin

Maniphest Tasks: T2949

Differential Revision: https://secure.phabricator.com/D5719

Details

Committed
Bob Trahan <bob.trahan@gmail.com>Apr 17 2013, 03:25
Pushed
aubortJan 31 2017, 17:16
Parents
rPH9d5fc041f691: Conpherence - fix some text to use "Message"
Branches
Unknown
Tags
Unknown

Event Timeline

Bob Trahan <bob.trahan@gmail.com> committed rPH58e35518b6b7: Hovercards - make 'em work a bit better (authored by Bob Trahan <bob.trahan@gmail.com>).Apr 17 2013, 03:25