Homec4science

Fix some small Diffusion file browse view bugs

Authored by epriestley <git@epriestley.com> on Jun 10 2011, 00:47.

Description

Fix some small Diffusion file browse view bugs

Summary:
"--date short" was introduced to git somewhere between 1.7.2.2 and 1.7.3.4,
despite 1.7.2.2 saying "--date <format>" in "git help blame". The older version
of git accepts "--date=short", however.

Also, the URI construction means you get "?view=" if you click a line number to
get a deep link, which I found vaguely annoying. Drop 'view' if we don't need
it.

Test Plan:
Looked at blame in my sandbox, although it worked before the date patch since I
have 1.7.3.4. Clicked a line number. Switched viewmodes.

Reviewed By: codeblock
Reviewers: codeblock, jungejason, tuomaspelkonen, aran
CC: aran, codeblock
Differential Revision: 423

Details

Committed
epriestley <git@epriestley.com>Jun 10 2011, 00:53
Pushed
aubortJan 31 2017, 17:16
Parents
rPH17306b7a92bb: Provide basic keyboard navigation support for Differential.
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH58ed932e5313: Fix some small Diffusion file browse view bugs (authored by epriestley <git@epriestley.com>).Jun 10 2011, 00:53