Homec4science

Clean up various pieces of dead/obsolete Differential code

Authored by epriestley <git@epriestley.com> on Mar 9 2014, 21:44.

Description

Clean up various pieces of dead/obsolete Differential code

Summary:
Ref T2222.

  • Removes DifferentialTasksAttacher, which has had no callsites for a very long time.
  • Moves differential.getrevisioncomments off DifferentialCommentQuery.
  • Moves Releeph churn field off DifferentialCommentQuery.
  • Removes dead code in DifferentialRevisionViewController.
  • Removes DifferentialException (no references).
  • Removes DifferentialRevision->loadComments() (no callsites).
  • Removes DifferentialRevision->loadReviewedBy() (all callsites updated).
  • Removes DifferentialCommentQuery (all callsites updated).

Test Plan: Mostly a lot of grep.

Reviewers: btrahan

Reviewed By: btrahan

CC: aran

Maniphest Tasks: T2222

Differential Revision: https://secure.phabricator.com/D8476

Details

Committed
epriestley <git@epriestley.com>Mar 11 2014, 21:02
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa49fec39be84: Move lint/unit test warning code forward to Transactions
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH592591e71538: Clean up various pieces of dead/obsolete Differential code (authored by epriestley <git@epriestley.com>).Mar 11 2014, 21:02