Homec4science

Correct RepositoryURI schema and propagate `adjust` exit code correctly

Authored by epriestley <git@epriestley.com> on Apr 18 2016, 17:03.

Description

Correct RepositoryURI schema and propagate adjust exit code correctly

Summary:
Fixes T10830.

  • The return code from storage adjust did not propagate correct.
  • There was one column issue which I missed the first time around because I had a bunch of unrelated stuff locally.

Test Plan:

  • Ran bin/storage upgrade -f with failures, used echo $? to make sure it exited nonzero.
  • Got fully clean bin/storage adjust by dropping all my extra local tables.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T10830

Differential Revision: https://secure.phabricator.com/D15746

Details

Committed
epriestley <git@epriestley.com>Apr 18 2016, 17:11
Pushed
aubortJan 31 2017, 17:16
Parents
rPHd844e5112794: Warn users about remote code execution in older Git
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH595f20381691: Correct RepositoryURI schema and propagate `adjust` exit code correctly (authored by epriestley <git@epriestley.com>).Apr 18 2016, 17:11