Homec4science

Do sampled profiling of requests

Authored by Nick Harper <nharper@fb.com> on Aug 25 2012, 00:14.

Description

Do sampled profiling of requests

Summary:
People have occasionally complained about phabricator being slow. We have
the access log to look at to see when slowness happens, but it doesn't tell
us much about why it happened. Since it's usually a sporadic issue that's
reported, it's hard to reproduce and then profile. This change will allow us
to collect sampled profiles so we can look at them when slowness occurs.

Test Plan:
checking that sampling works correctly:

  • set rate to 0; do several page loads; check no new entries in table
  • set rate to 1; check that there's a new row in the table for each page load
  • set rate to 10; check that some requests write to table and some don't

check new ui for samples:

  • load /xhprof/list/all/, see a list with a lot of samples
  • load /xhprof/list/sampled/, see only sampled runs
  • load /xhprof/list/manual/, see only non-sampled runs
  • load /xhprof/list/my-runs/, se only my manual runs

Reviewers: vrana, epriestley

Reviewed By: epriestley

CC: aran, Korvin

Differential Revision: https://secure.phabricator.com/D3458

Details

Committed
Nick Harper <nharper@fb.com>Sep 17 2012, 19:53
Pushed
aubortJan 31 2017, 17:16
Parents
rPHa52af0b3ae89: Make it more clear that "Public" really means "Public"
Branches
Unknown
Tags
Unknown

Event Timeline

Nick Harper <nharper@fb.com> committed rPH5978bbfc64e2: Do sampled profiling of requests (authored by Nick Harper <nharper@fb.com>).Sep 17 2012, 19:53