Homec4science

Disable caching of remarkup previews

Authored by epriestley <git@epriestley.com> on Feb 22 2015, 14:39.

Description

Disable caching of remarkup previews

Summary:
We currently cache previews, but the vast majority of previews are never rendered again (e.g., they're a preview of someone partway through typing a comment).

Especially when editing large documents (Legalpad, Phriction), this can bloat the markup cache with data that will never be read and won't get purged for 30 days.

In particular, most of the data on admin.phacility.com is currently 1,000 previews of legalpad documents as I made minor edits to them over the course of several hours.

This isn't a big concern, but it's a very easy fix.

Test Plan:

  • Previewed a legalpad document, verified that cache rows were not written as I mashed the keyboard.
  • Saved the document, verified a new cache row was written.

Reviewers: btrahan

Reviewed By: btrahan

Subscribers: epriestley

Differential Revision: https://secure.phabricator.com/D11832

Details

Committed
epriestley <git@epriestley.com>Feb 22 2015, 14:39
Pushed
aubortJan 31 2017, 17:16
Parents
rPHed7823f57716: Allow subscriptions to decline to generate an invoice
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH59ae91a5ce84: Disable caching of remarkup previews (authored by epriestley <git@epriestley.com>).Feb 22 2015, 14:39