Restore "Accept", "Reject" and "Resign" actions to Differential on EditEngine
5a6643f36ff8
Actions

Authored by epriestley <git@epriestley.com> on Dec 29 2016, 19:35.

Description

Restore "Accept", "Reject" and "Resign" actions to Differential on EditEngine

Summary:
Ref T11114. Some rough edges, but this largely makes Accept, Reject and Resign work in the new EditEngine comment area.

Ref T11050. This lays a little bit of groundwork for having "resign" mean "I don't want to review this, even if projects or packages I'm a member of need to", not just "remove me personally as a user reviewer".

Test Plan: Accepted, rejected and resigned from revisions without any major state issues.

Reviewers: chad

Reviewed By: chad

Maniphest Tasks: T11114, T11050

Differential Revision: https://secure.phabricator.com/D17113

Details

Committed

epriestley <git@epriestley.com>

Dec 31 2016, 19:09

Pushed

aubort

Jan 31 2017, 17:16

Parents

rPH8b74cd481a47: Restore "Commandeer" action to Differential on EditEngine

Branches

Unknown

Tags

Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH5a6643f36ff8: Restore "Accept", "Reject" and "Resign" actions to Differential on EditEngine (authored by epriestley <git@epriestley.com>).Dec 31 2016, 19:09

Changes (7)

				Path
	M			src/__phutil_library_map__.php
	M			src/applications/differential/constants/DifferentialReviewerStatus.php
	M			src/applications/differential/editor/DifferentialRevisionEditEngine.php
	A			src/applications/differential/xaction/DifferentialRevisionAcceptTransaction.php
	M			src/applications/differential/xaction/DifferentialRevisionActionTransaction.php
	A			src/applications/differential/xaction/DifferentialRevisionRejectTransaction.php
	A			src/applications/differential/xaction/DifferentialRevisionResignTransaction.php