Homec4science

Show loading state and fix reticles in Pholio

Authored by epriestley <git@epriestley.com> on Mar 5 2013, 01:59.

Description

Show loading state and fix reticles in Pholio

Summary:
Fixes T2643. Show a loading state (currently just making the image transparent, but we could do something fancier) when an image is loading.

Fixes T2648. Cleans up the double draws we were previously doing.

Makes thumbnails react to mousedown in addition to click so they feel a little snappier. Make them stop reacting to control click, command click, etc.

Test Plan: Used setTimeout() to simulate a 1s image load delay, switched between images.

Reviewers: chad

Reviewed By: chad

CC: aran

Maniphest Tasks: T2643, T2648

Differential Revision: https://secure.phabricator.com/D5219

Details

Committed
epriestley <git@epriestley.com>Mar 5 2013, 01:59
Pushed
aubortJan 31 2017, 17:16
Parents
rPH9aedb3c3c18a: Clearly show draft vs nondraft inline comments
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH5a7d9fb522f4: Show loading state and fix reticles in Pholio (authored by epriestley <git@epriestley.com>).Mar 5 2013, 01:59