Homec4science

Fix file PHID extraction in Owners and Differential

Authored by epriestley <git@epriestley.com> on Nov 16 2015, 18:53.

Description

Fix file PHID extraction in Owners and Differential

Summary:
Ref T9787. To fix this, I want to change how file PHIDs are extracted slightly: specifically, I'm going to extract them later in the editing process.

Before doing this, clean up a couple of bad implementations:

  • Owners extracts its description as a file PHID. This is an error.
    • Extract the description as a remarkup block instead.
    • Add an edge table so stuff like file attachment works properly.
  • Differential has a no-op extract method. This is presumably just a copy/paste issue from long ago.

Test Plan:

  • Edited a revision in Differential.
  • Dropped a file into the description of an Owners package.
    • Before change: this did not attach the file.
    • After change: the file now attaches properly and shows up as "Attached" in the file details.

Reviewers: chad, joshuaspence

Reviewed By: joshuaspence

Subscribers: joshuaspence

Maniphest Tasks: T9787

Differential Revision: https://secure.phabricator.com/D14493

Details

Committed
epriestley <git@epriestley.com>Nov 17 2015, 17:36
Pushed
aubortJan 31 2017, 17:16
Parents
rPH26a235ab8a18: Make Herald rules subscribable
Branches
Unknown
Tags
Unknown

Event Timeline

epriestley <git@epriestley.com> committed rPH5aae89babb73: Fix file PHID extraction in Owners and Differential (authored by epriestley <git@epriestley.com>).Nov 17 2015, 17:36